Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magic value for P4 (ESPTOOL-921) #1008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add magic value for P4 (ESPTOOL-921) #1008

wants to merge 1 commit into from

Conversation

mutatrum
Copy link

The P4 on my dev board reports 0xFFFFFFFF as magic value. It's an engineering sample and it's self reporting as silicon version v0.1. I can't really judge if this should be merged though.

@mutatrum
Add magic value for P4
dd58a36 
The P4 on my dev board reports 0xFFFFFFFF as magic value. It's an engineering sample and it's self reporting as silicon version v0.1. I can't really judge if this should be merged though.
@github-actions GitHub Actions
Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add magic value for P4":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello mutatrum, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against dd58a36

@github-actions github-actions bot changed the title Add magic value for P4 Add magic value for P4 (ESPTOOL-921) Sep 12, 2024
@radimkarnis
Copy link
Collaborator

Hi @mutatrum,
thanks for taking the time to report this, and even to send a PR!

We have recently found out that the magic number autodetection method is not reliable for ESP32-P4, as the value at the arbitrary address (CHIP_DETECT_MAGIC_REG_ADDR) can change between runs. Due to this, we are now considering changing the address (for all of the previous targets as well).

Fortunately, this is shouldn't be a big deal for P4, as autodetection based on the magic number is just a fallback method. The get_security_info method is primarily used and reliable.

@mutatrum mutatrum mentioned this pull request Sep 13, 2024
Closed
@radimkarnis
Copy link
Collaborator

We will keep this issue open as a tracker until it's resolved.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutatrum @radimkarnis